fix: only iterate over directories in the plugins/ directory #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stratus3D
force-pushed
the
tb/plugins-ds-store-fix
branch
2 times, most recently
from
0d279b3
to
9fa3657
Compare
Stratus3D
changed the title
Stratus3D
force-pushed
the
tb/plugins-ds-store-fix
branch
from
a9f26f0
to
9936fab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #1029
The shell glob pattern
dir/*matches any files indir/,dir/*/matches only directories indir. When iterating over the plugins directory we only care about directories, since only they can represent plugins.