test: Do not run Nu test if it does not exist #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperupcall
force-pushed
the
fix-nu-test
branch
from
c68c57d
to
edb42e9
Compare
Stratus3D
reviewed
Jan 6, 2023
|
|
||
| if ! command -v nu; then | ||
| skip "Nu is not installed" | ||
| fi |
There was a problem hiding this comment.
Just curious: why did you move this if from the top of the setup function to the bottom?
There was a problem hiding this comment.
I believe I wanted to make it clear the the current directory was an invariant with respect to the test file, so moving it to the very top would accomplish that. I think it matches other test files as well
Stratus3D
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is more automatic compared against
SKIP_NUSHELL_TESTS.