Support force (re)installing #1546
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Stratus3D Please may I have your thoughts on this approach? I haven't added documentation or updated any required tests as yet as I wanted to see if you would be in support of such an idea. |
|
I think by the very least, the reinstall should be implemented with some sort of flag for consistency. Going through #244, it seems this has been mentioned here. I don't have any comments about the approach, but it seems there were some issues with transactional consistency as mentioned in that issue. There were some approaches mentioned here, and I wonder if it would be better implementing one of them rather than going with a naive approach. Because I think in most cases, the directory would already exist and we would want to reinstall over that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new
ASDF_environment variable calledASDF_FORCE_INSTALLwhich can be set totrueto force a (re)install.Taking Ruby as an example, it's desirable to want to re-install (instead of uninstall and install) when you want to apply a new set of Ruby patches, but don't want to lose the currently installed Ruby gems.