Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add messages for bulk install visibility #1754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add messages for bulk install visibility #1754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/functions/installs.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ install_tool_version() {
if [ -d "$install_path" ]; then
printf "%s %s is already installed\n" "$plugin_name" "$full_version"
else
printf "%s %s is being downloaded\n" "$plugin_name" "$full_version"

if [ -f "${plugin_path}/bin/download" ]; then
# Not a legacy plugin
Expand All @@ -216,6 +217,7 @@ install_tool_version() {
local download_exit_code=$?
if [ $download_exit_code -eq 0 ]; then
(
printf "%s %s is being installed\n" "$plugin_name" "$full_version"
# shellcheck disable=SC2031
export ASDF_INSTALL_TYPE=$install_type
# shellcheck disable=SC2031
Expand Down
14 changes: 10 additions & 4 deletions test/install_command.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ EOM
printf 'dummy 1.0.0\nother-dummy 2.0.0' >"$PROJECT_DIR/.tool-versions"
run asdf install dummy other-dummy
[ "$status" -eq 1 ]
[ "$output" = "Dummy couldn't install version: other-dummy (on purpose)" ]
[[ "$output" == *"Dummy couldn't install version: other-dummy (on purpose)" ]]
[ ! -f "$ASDF_DIR/installs/dummy/1.0.0/version" ]
[ ! -f "$ASDF_DIR/installs/other-dummy/2.0.0/version" ]
}
Expand Down Expand Up @@ -227,7 +227,7 @@ pre_asdf_install_dummy = echo will install dummy $1
EOM

run asdf install dummy 1.0.0
[ "$output" = "will install dummy 1.0.0" ]
[[ "$output" == *"will install dummy 1.0.0" ]]
}

@test "install command executes configured post plugin install hook" {
Expand All @@ -236,7 +236,7 @@ post_asdf_install_dummy = echo HEY $version FROM $plugin_name
EOM

run asdf install dummy 1.0.0
[ "$output" = "HEY 1.0.0 FROM dummy" ]
[[ "$output" == *"HEY 1.0.0 FROM dummy" ]]
}

@test "install command without arguments installs versions from legacy files" {
Expand Down Expand Up @@ -295,12 +295,18 @@ EOM
[ "$(cat "$ASDF_DIR/installs/dummy/1.1.0/version")" = "1.1.0" ]
}

@test "install_command outputs installing and downloading messages" {
run asdf install dummy 1.0.0
[ "$status" -eq 0 ]
[[ "$output" == "dummy 1.0.0 is being downloaded"*"dummy 1.0.0 is being installed"* ]]
}

@test "install_command fails when download script exits with non-zero code" {
run asdf install dummy-broken 1.0.0
[ "$status" -eq 1 ]
[ ! -d "$ASDF_DIR/downloads/dummy-broken/1.1.0" ]
[ ! -d "$ASDF_DIR/installs/dummy-broken/1.1.0" ]
[ "$output" = "Download failed!" ]
[[ "$output" == *"Download failed!" ]]
}

@test "install_command prints info message if plugin does not support preserving download data if --keep-download flag is provided" {
Expand Down