remove codecov travis #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimene74
requested review from
billcobbler,
masottile and
byott
and removed request for
a team
ensary
reviewed
May 30, 2024
| @@ -20,8 +20,3 @@ jobs: | |||
| run: make integration | |||
| - name: Test Coverage | |||
| run: make coverage | |||
| - name: Upload Coverage | |||
There was a problem hiding this comment.
q: this will result in missing quality gate. Codecov reports on coverage on the PR. We need an alternative before we remove this. Can we discuss before merging?
There was a problem hiding this comment.
merging for now, per our discussion earlier. We don't have anywhere to upload in codecov anymore
aureagdm
requested review from
aureagdm
and removed request for
billcobbler,
masottile and
byott
aureagdm
approved these changes
Sep 27, 2024
gcase555
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.