-
Notifications
You must be signed in to change notification settings - Fork 262
Allow duplicate keys #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow duplicate keys #59
Conversation
Thanks for the pull request! The travis CI build has failed, but it doesn't look like it's anything related to your PR. The commits look good and I would like to merge, but I don't want to until we have a clean build. Would you mind pushing again and seeing if this is a transient problem? |
I think the problem is with the develop branch. .travis.yml lists a Node version of 0.9, but the travis CI VM doesn't have 0.9 installed. |
Looks like that's right. But, this build was working in the past. Perhaps this particular build node is not the same as the others and doesn't have 0.9 installed (while the others do). |
Looks like you can trigger a re-run of a Travis CI build if you're logged in. |
Thanks for fixing the build issue! @jordanbtucker, do you know how to git rebase? If you rebase this branch to the latest master now, the CI should pass again. We should add a CONTRIBUTING.md, but as a matter of habit, it's always nice to rebase branches/pull requests before merging them, to ensure clean merges (not just logistically but logically too). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: 4-spaces here too.
Thanks for the rebase tip. |
Fixes #57