Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'ignore' option, tests for it and it's description in the README. #31

Closed
wants to merge 4 commits into from

Conversation

bondden
Copy link

@bondden bondden commented Jan 26, 2016

Tried to follow the current code style and use ES5 for compatibility reasons.

@bondden bondden mentioned this pull request Jan 26, 2016
@trainerbill
Copy link

can this merge? need an ignore or glob option

@xinshangshangxin
Copy link

when can merge it; i also need a ignore option,
although I found another package to solve it

@angelxmoreno
Copy link

any plans to merge this?

@xinshangshangxin
Copy link

The auth Latest commit 824b9f1 on 24 Mar 2015; so I search another node-require-directory

@lbeschastny lbeschastny mentioned this pull request May 3, 2016
@sergiomichels
Copy link

14 pending pull requests, I think it's time to try the node-require-directory indeed.

@aseemk
Copy link
Owner

aseemk commented Oct 24, 2016

Hey folks,

I'm sorry for my delay in responding to these issues and PRs. I've found it hard to find the time and motivation to maintain an active role in growing this project. The module has worked perfectly fine for my company in production for years now, and I've been hesitant to add features to it and risk making it bloated when it currently is nice and simple.

But I now realize that the module can still grow for other people's needs, and it shouldn't hurt us. I just can't commit to taking on the maintainer role anymore.

Is there anyone that's passionate and interested in maintaining this project? If so, I'll be happy to add you as a collaborator to this repo as well as to the package on npm. Let me know!

Thank you again for all your contributions.

Cheers,
Aseem

@yocontra
Copy link
Collaborator

yocontra commented Feb 7, 2018

@aseemk I'll take it - I've been using this for years across a number of applications, but a few basic features (like this one) + maintenance would be nice.

@aseemk
Copy link
Owner

aseemk commented Feb 7, 2018

@contra: Invited. Thank you!

@yocontra
Copy link
Collaborator

yocontra commented Feb 7, 2018

Hi (new maintainer) - I've merged #27 which does the same thing, and was the first PR submitted to solve this problem. You should be able to achieve the same functionality with that. I'll be publishing it to npm shortly.

@yocontra yocontra closed this Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants