Fixing Enumerable#contains deprecation

[ef4]

As documented in the deprecation guide, addons can use this polyfill to avoid the deprecation while still supporting older versions of Ember.

Closes #82

(The test suite was already failing on beta and canary.)

[asennikov]

Fixed deprecation in that commit ( thx for the polyfill hint) - 7cc865a

Also, I like your switch to didRender from observers, I'd like to incorporate that, but I remember there were some issues with this approach before. I'll check again.
However, I'm not sure with open -> _open rename you've added, as these methods are public and are used within other related components.

[ef4]

However, I'm not sure with open -> _open rename you've added, as these methods are public and are used within other related components.

If you need that to maintain some backward compatibility that makes sense. But, going forward I would recommend against using methods on components as API between components.

If open and close are things that can be done by an ancestor component of this one, it should be expressed as data coming down (like {{g-map-infowindow isOpen=(something ...)}}).

If open and close are things that can be done by a descendant component of this one, they should be yielded downward as actions that can come back up. {{yield (hash open=(action "open") close=(action "close"))}}

[asennikov]

I agree with you. My problem with that initially was that you can't just send isOpen down and expect popup to appear, you need to ensure that the state is in sync with google map object, which does not belong to a single component it is shared between all of them, if it makes sense.

However, I see how that could be improved and this should be refactored, but carefully.

[xomaczar]

@asennikov can you release a new version with this fix.

[asennikov]

@xomaczar yep, done

[xomaczar]

Thx

Andrey S. Khomenko

On Nov 14, 2016, at 6:17 PM, Alexander Sennikov notifications@github.com wrote:

@xomaczar yep, done

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[steveszc]

Closing. The original Enumerable#includes changes have already been merged in a separate commit.
The need to move to a DDAU architecture is now documented in issue #97. @ef4 thanks for getting the ball rolling on this.