-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directory Client #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronenh
force-pushed
the
directory-client
branch
2 times, most recently
from
October 13, 2023 21:42
a7c569d
to
e53ba36
Compare
ronenh
force-pushed
the
directory-client
branch
from
October 13, 2023 21:57
e53ba36
to
d0a68c1
Compare
move test files to _test package namespace
gertd
approved these changes
Oct 16, 2023
gertd
added a commit
that referenced
this pull request
Oct 17, 2023
* Directory Client (#7) * Add directory client * update readme * Move directory client to /v2 * Update linter * move test files to _test package namespace --------- Co-authored-by: Gert Drapers <gert.drapers@live.com> * 2 minute timeout for lint actio (#10) --------- Co-authored-by: Gert Drapers <gert.drapers@live.com>
ronenh
added a commit
that referenced
this pull request
Oct 31, 2023
* Directory Client (#7) * Add directory client * update readme * Move directory client to /v2 * Update linter * move test files to _test package namespace --------- Co-authored-by: Gert Drapers <gert.drapers@live.com> * 2 minute timeout for lint actio (#10) --------- Co-authored-by: Gert Drapers <gert.drapers@live.com>
ronenh
added a commit
that referenced
this pull request
Oct 31, 2023
* Add directory client * update readme * Move directory client to /v2 * Update linter * move test files to _test package namespace --------- Co-authored-by: Gert Drapers <gert.drapers@live.com>
ronenh
added a commit
that referenced
this pull request
Oct 31, 2023
* Directory Client (#7) * Add directory client * update readme * Move directory client to /v2 * Update linter * move test files to _test package namespace --------- Co-authored-by: Gert Drapers <gert.drapers@live.com> * 2 minute timeout for lint actio (#10) --------- Co-authored-by: Gert Drapers <gert.drapers@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
client/directory
package with the following types:directory.Client
: A struct withReader
,Writer
,Importer
, andExporter
fields.directory.Config
: Configuration for constructing a directory client.A directory client can be created in a similar way as authorizer clients:
Config can be used to create a directory client with customized configuration for each service:
In this case,
dir.Reader
anddir.Writer
are initialized with the given configuration.dir.Importer
anddir.Exporter
are nil.It's also possible to provide fallback configuration that is used unless overridden:
In this case, all services connect to the hosted directory, except
reader
which connects to localhost.