Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add importer support for delete object with relations #93

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Add importer support for delete object with relations #93

merged 4 commits into from
Jun 12, 2024

Conversation

gertd
Copy link
Member

@gertd gertd commented Jun 10, 2024

No description provided.

@coveralls
Copy link

coveralls commented Jun 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9453441096

Details

  • 0 of 54 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 27.141%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/directory/v3/importer.go 0 54 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/directory/v3/importer.go 2 2.99%
Totals Coverage Status
Change from base Build 9277923225: -0.3%
Covered Lines: 1182
Relevant Lines: 4355
💛 - Coveralls

@gertd gertd marked this pull request as ready for review June 12, 2024 16:23
@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9486200493

Details

  • 0 of 54 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 25.066%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/directory/v3/importer.go 0 54 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/directory/v3/importer.go 2 2.99%
Totals Coverage Status
Change from base Build 9467390156: -0.4%
Covered Lines: 857
Relevant Lines: 3419
💛 - Coveralls

@gertd gertd merged commit c03fabc into main Jun 12, 2024
2 checks passed
@gertd gertd deleted the del-obj-with-relations branch June 12, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carabasdaniel carabasdaniel carabasdaniel approved these changes

@ronenh ronenh Awaiting requested review from ronenh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gertd @coveralls @carabasdaniel