Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim requested path comparison when using authorizer with local bundles #15

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Trim requested path comparison when using authorizer with local bundles #15

merged 1 commit into from
Jul 26, 2022

Conversation

carabasdaniel
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2740802226

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 22.671%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bundles.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
bundles.go 1 0%
Totals Coverage Status
Change from base Build 2739739702: -0.04%
Covered Lines: 258
Relevant Lines: 1138
💛 - Coveralls

@carabasdaniel carabasdaniel marked this pull request as ready for review July 26, 2022 18:36
stefanba3
stefanba3 reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@stefanba3 stefanba3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the authorizer tests with this change, stepping through the path calculation in one of the calls to DecisionTree. It looks good to me.

@stefanba3 stefanba3 merged commit 4ed7f08 into main Jul 26, 2022
@stefanba3 stefanba3 deleted the fix-bundles branch July 26, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanba3 stefanba3 stefanba3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carabasdaniel @coveralls @stefanba3