Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the go-topaz-ui v0.0.1 #157

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Use the go-topaz-ui v0.0.1 #157

merged 2 commits into from
Nov 14, 2023

Conversation

carabasdaniel
Copy link
Contributor

No description provided.

Base automatically changed from v3 to main November 4, 2023 02:50
Copy link

github-actions bot commented Nov 13, 2023

Pull Request Test Coverage Report for Build 6868402646

  • 1 of 49 (2.04%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 42.509%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/app/topaz.go 1 13 7.69%
pkg/app/console.go 0 36 0.0%
Totals Coverage Status
Change from base Build 6813433694: 0.7%
Covered Lines: 1413
Relevant Lines: 3324

💛 - Coveralls

@carabasdaniel carabasdaniel changed the title Prepare topaz to use the go-topaz-ui package Use the go-topaz-ui v0.0.1 Nov 14, 2023
@carabasdaniel carabasdaniel marked this pull request as ready for review November 14, 2023 08:16
@gertd
Copy link
Member

gertd commented Nov 14, 2023

I see that CONSOLE_VERSION is still defined in ci.yaml and mage/magefile.go; these should no longer be required, as topaz now consumes the console as a go package.

@gertd gertd merged commit d81ad93 into main Nov 14, 2023
5 checks passed
@gertd gertd deleted the topazui branch November 14, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants