Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON decode fails if buf empty #172

Merged
merged 1 commit into from
Nov 6, 2023
Merged

JSON decode fails if buf empty #172

merged 1 commit into from
Nov 6, 2023

Conversation

oanatmaria
Copy link
Contributor

If result is

{
  "results": [],
  "objects": {},
  "page": {
    "next_token": ""
  }
}

ast.ValueFromReader fails to decode empty buf

Copy link

github-actions bot commented Nov 6, 2023

Pull Request Test Coverage Report for Build 6771663773

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 41.792%

Changes Missing Coverage Covered Lines Changed/Added Lines %
builtins/edge/ds/relation.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
builtins/edge/ds/relation.go 1 30.0%
Totals Coverage Status
Change from base Build 6766369268: 0.0%
Covered Lines: 1413
Relevant Lines: 3381

💛 - Coveralls

@gertd gertd merged commit aae9010 into main Nov 6, 2023
5 checks passed
@gertd gertd deleted the dont_fail_id_results_nil branch November 6, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants