Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support user resolution by key #79

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Support user resolution by key #79

merged 4 commits into from
Apr 28, 2023

Conversation

ronenh
Copy link
Contributor

@ronenh ronenh commented Apr 26, 2023

This PR includes two changes in preparation for the removal of internal IDs:

  1. ds.user can take either id or key.
  2. In addition to resolving users by identity or id, we now attempt to resolve by key too.

@ronenh ronenh mentioned this pull request Apr 26, 2023
Closed
@github-actions
Copy link

Pull Request Test Coverage Report for Build 4812720949

  • 20 of 26 (76.92%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 38.194%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/app/impl/jwt.go 11 17 64.71%
Totals Coverage Status
Change from base Build 4810316457: 0.006%
Covered Lines: 1184
Relevant Lines: 3100
💛 - Coveralls

@ronenh ronenh marked this pull request as ready for review April 27, 2023 20:35
@ronenh ronenh merged commit ae3ff83 into main Apr 28, 2023
@ronenh ronenh deleted the resolve-by-key branch April 28, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogazitt ogazitt ogazitt approved these changes

@carabasdaniel carabasdaniel Awaiting requested review from carabasdaniel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ronenh @ogazitt