Fixed compilation failures related to usage of type bool #481
Conversation
| #include "asf_meta.h" | ||
| #include "fft.h" | ||
| #include "fft2d.h" | ||
| #include "ifm.h" | ||
| #include <stdbool.h> |
There was a problem hiding this comment.
Duplicate. ifm.h is duplicated too.
There was a problem hiding this comment.
Fixed with c64f1fa
| @@ -28,7 +28,7 @@ typedef struct { | |||
|
|
|||
| typedef struct { | |||
| double mean; | |||
| double true; | |||
| double isTrue; | |||
There was a problem hiding this comment.
The name of this member is changed, but there are no changes to code using that member anywhere I can see in this pull request. Is it disused?
There was a problem hiding this comment.
The struct seems to be unused. propagate.h is only included in propagate.c, however anomaly_t is not used in propagate.c.
|
Is there something that still needs to be done to get this PR closer to being merged? I've noticed, that the first commit in this PR has become obsolete with the removal of the offending struct Leaving that aside, without the other commits in this PR (9c1fae9, c64f1fa) , it is still impossible to compile ASF MapReady with gcc on Debian Stretch. (gcc 6.3.0, Debian 9.5) |
|
Closing this now in favor of a cleaner, new PR. |
|
Still in favor of more cowbell...
Cougar
On Wed, Mar 20, 2019 at 4:08 AM Felix Glaser ***@***.***> wrote:
Closing this now in favor of a cleaner, new PR.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#481 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFcsO_3dBm3dPHwKOZe6O0LNPKVG9QIKks5vYhaUgaJpZM4OanOX>
.
--
Clay Allen
University of Alaska Fairbanks
907-699-8878
|
Using gcc 6.3 on Debian 9 (Stretch), compilation fails because:
anomaly_tinsrc/asf_meta/propagate.hthere is a field labelled "true"include/ifm.hthe type definition for bool is problematicThis pull request fixes these problems by:
bool