Refactor: Remove Excessive Data and Simplify States in GeneratorComponent #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ard body using the title prop
…ead of description
…tates in GeneratorComponent.js to use the title to display card heading
ash1eygrace
deleted the
refactor/remove-unused-data-from-generator-data-array
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details about these changes are outlined in Redesign/Refactor: Simplify data passed into GeneratorComponent.js from GeneratorList.js.
This pull request refactors the
data/GeneratorListto remove excessive data and simplify our states inGeneratorComponent. The following changes have been made:h1property in the objects of the data has been removed, and thetitleproperty has been updated to be used as theh1tag in line 41 ofGeneratorComponent.js.Card.Textcomponent's initial state is now conditionally rendered based on thedataLoadedand response states using a ternary operator.description2is now being used{description2}
instead of descriptoin.response1,response2, andresponse3properties in the data objects have been removed, and new states have been set for theGeneratorComponent.jsto display appropriate messages using thetitleprop.These changes have been thoroughly tested, and everything works as expected.