Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline variables support #127

Merged

Conversation

ledoyen
Copy link
Contributor

@ledoyen ledoyen commented Nov 30, 2020

Hello,

I have the need explained in #104.

So here is a proposition to get it work:

  • Support multi-line variables on single-line with double quote strings and the \n character for newlines
  • Support multi-line variables with line breaks using double quotes as delimiter

This addition follow the behavior described in the dotenv ruby tool: https://github.com/bkeepers/dotenv#multi-line-values

Hoping this is satisfying for you and @vladAnk

With double quote strings and the `\n` character for newlines as
described in the documentation of the ruby **dotenv** tool.
https://github.com/bkeepers/dotenv#multi-line-values
Using double quotes as delimiter as
described in the documentation of the ruby **dotenv** tool.
https://github.com/bkeepers/dotenv#multi-line-values

Fix ashald#104
@camlesom
Copy link

camlesom commented Feb 3, 2021

@ashald was wondering if you'd be able to merge this PR as I ran into this problem and can't really find a reasonable way around multiline env variables.

@ashald
Copy link
Owner

ashald commented Feb 6, 2021

Hi! Thanks a lot for your contribution!
I'll try to look into your PR as soon as I can.
Recently I don't have much time for OSS activity, unfortunately. That being said, I don't want to abandon this plugin either. I hope to find some time review recent contributions in the next few months, and will be sure to check your work. Please keep your branch in place so that I can learn from your findings!

P.S.: Hope you can use yaml multi-line string smeanwhile

@jonatascastro12
Copy link

Any news on this PR?

@ashald
Copy link
Owner

ashald commented Jun 10, 2021

Not yet - I don't have time for OSS activity right now.
Will review outstanding PRs and cut a new release whenever I get a chance though. Appreciate your contribution!
In the meantime, you should be able to get your own build and install plugin from file to get this working.

@ashald ashald merged commit 5b4045f into ashald:develop Oct 2, 2022
@ashald
Copy link
Owner

ashald commented Oct 2, 2022

Looks great - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants