-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .envrc(direnv) support #160
Conversation
@ashald Would you take a look? |
Incidentally, you don't need to add |
@ashald Do you have a chance to review this PR? |
I'd be glad to merge |
@ashald Thank you for reviewing this PR. I updated this PR not to break the core module abstraction. Would you take a look again? |
@shinichy ugh, my apologies, I just worked on refactoring some mess in core module to make the interface cleaner. I just submitted a release, and unless there is a critical bug, I don't plan to make any changes to the code. Could you please rebase your changes one more? Apologies for back and forth. |
@ashald No worries. I fixed all the conflicts. Could you please take a look again? |
modules/core/src/main/java/net/ashald/envfile/providers/direnv/DirenvProvider.java
Show resolved
Hide resolved
Hi @shinichy, apologies for a delayed reply. What I can offer to you instead is the extension point interface such that you could pack your changes as an independent plugin that relies on extension points provided by EnvFile, but can be installed separately. Please let me know if anything is missing in the current interface that would be necessary for you to implement the above. P.S.: Alternatively, the latest version of EnvFile can execute any given file and interpret stdout as .env or JSON/YAML. To the best of my understanding, you could wrap a call to direnv in a tiny script that would just output env vars you set. |
@ashald Thanks for letting me know. I don't use IntelliJ and direnv these days, so I'll check your suggestions when I have a chance to use IntelliJ again. |
Fixes #102
DirenvProvider
to support.envrc
filegetFileNamePredicate
andshowHiddenFiles
methods toEnvVarsProviderFactory
interface to allow selecting only.envrc
file.