Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support FailureDiffs without configuration #71

Closed
wants to merge 2 commits into from
Closed

Support FailureDiffs without configuration #71

wants to merge 2 commits into from

Commits on Jun 1, 2017

  1. Define a FailureDiffs folder 

    This took an unexpected turn. There's a nice interface defined for the
reference folder:
https://github.com/facebook/ios-snapshot-test-case/blob/master/FBSnapshotTestCase/FBSnapshotTestController.h#L72

That's not the case for the failure diffs folder. I had to get creative
so I used the setenv in order to give this failure diffs folder mapping
by default. See here to know how it's used in the FBSnapshotTestCase
project:
https://github.com/facebook/ios-snapshot-test-case/blob/master/FBSnapshotTestCase/FBSnapshotTestController.m#L266-L268
    @hugobast
    hugobast committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    ace0c38 View commit details
    Browse the repository at this point in the history

  2. A note about test failure artifacts and vcs

    @hugobast
    hugobast committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    3c1724e View commit details
    Browse the repository at this point in the history