feat: add callback for invocation end with streaming functions #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3c62e71 is published under https://www.npmjs.com/package/@skn0tt/lambda-local/v/2.1.2 for anybody who needs this right now. |
|
Thanks for the PR ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streaming functions can end the response stream before they finish their invocation. Here's an example function where this applies:
If we want to test that this works as intended, we need to ensure that the Lambda continues running after the response stream ended.
For most Lambdas, that's straightforward because the Lambda is killed immediately after the response is sent. Checking if all required work was completed once
opts.callbackis called is sufficient in that case.For streaming Lambdas though,
opts.callbackis already called when the response headers are sent (aka when.writeis first called). This is much earlier, and the Lambda can still perform operations after that.This PR adds a
onInvocationEndcallback that gets notified when the Promise returned by the handler resolves. At this point, all operations should be completed, because AWS might kill the Lambda afterwards.onInvocationEndcan be used in testing to ensure that's the case.