-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tn/add project vars #934
Tn/add project vars #934
Changes from 10 commits
b446523
6333911
d2d2055
c63dcdb
a805347
79a79d6
e373ba6
fcac94d
dddddc1
cbabd0b
61e20c8
be5f371
f52a73c
a0c1f6c
44c4050
7ecae28
8cb3382
f4a400d
cf84160
71c9331
fd91886
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
-- +migrate Up | ||
CREATE TABLE global_vars ( | ||
id INT AUTO_INCREMENT, | ||
name VARCHAR(255) NOT NULL UNIQUE, | ||
value VARCHAR(255) NOT NULL, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is VARCHAR(255) large enough? What if* I wanted to pass an RSA key or longer document? Maybe this isn't a huge deal for the first pass since we can grow the field later? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh that's a good point - yeah I can def change that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. changed the type to TEXT - how does that sound? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just tested by adding a really long doc and the UI 'breaks' so I'll fix that as well |
||
created_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, | ||
updated_at TIMESTAMP, | ||
PRIMARY KEY (id) | ||
) ENGINE=INNODB AUTO_INCREMENT=1 DEFAULT CHARSET=utf8; | ||
|
||
-- +migrate Down | ||
DROP TABLE global_vars; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha I'm all about 1) honoring convention and 2) referencing media franchises from my childhood in my work