Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress comment media download? #25

Closed
iglazer opened this issue Jul 12, 2024 · 6 comments
Closed

Suppress comment media download? #25

iglazer opened this issue Jul 12, 2024 · 6 comments

Comments

@iglazer
Copy link

iglazer commented Jul 12, 2024

I've got an old blog I am trying to convert and it has comments which have links to media (gravars and more). One of the old comments has a link to media which is 404'ing, which isn't a big deal because I don't really want to port the comments of the blog to Hugo. Anyway to either suppress 404's thrown via converting comments or suppress the conversion of comments all together?

@ashishb
Copy link
Owner

ashishb commented Jul 14, 2024

Hi @iglazer you should still get the result but with a lot of warnings. Is the migration failing due to the warnings?

@iglazer
Copy link
Author

iglazer commented Jul 14, 2024

It looks like a post is failing migration because of a 404 for an image:
{"level":"fatal","time":1720982186,"message":"Error: error fetching media file http://eldred.cc/images/mouse.gif: error fetching media http://eldred.cc/images/mouse.gif: 404 Not Found"}

That's the last message in the log

@ashishb
Copy link
Owner

ashishb commented Jul 15, 2024

Can you try without -download-media flag?
I want you to know that failure fast is intentional here as I don't want to claim an incomplete migration as a success. However, I may put a failure budget where a certain number or percentage of media downloads can fail, which might be OK.

@iglazer
Copy link
Author

iglazer commented Jul 15, 2024 via email

@ashishb
Copy link
Owner

ashishb commented Jul 27, 2024

Thanks, I will add that option

@ashishb
Copy link
Owner

ashishb commented Jul 28, 2024

@iglazer right now, no, and this is intentional.
If the download-media flag is enabled, I don't want to give a fake sense of success if one or more media files cannot be downloaded.

@ashishb ashishb closed this as completed Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants