Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optuna default values #235

Merged
merged 4 commits into from
Feb 19, 2022
Merged

Conversation

nils-werner
Copy link
Contributor

A big chunk of the parameters in /configs/hparams_search/mnist_optuna.yaml were the default values from the documentation. I don't think these values need to be repeated here, right?

@ashleve
Copy link
Owner

ashleve commented Dec 27, 2021

I like having the default parameters there, since the template purpose is also educational. Having explicit statement of all the possible parameters helps to realize the possibilities. For example, it's important to be aware about the n_startup_trials param since it determines how many random runs will be executed at the beginning of search, before the optimization sampling starts.

@ashleve
Copy link
Owner

ashleve commented Dec 27, 2021

Although it should probably be better documented with some comments

@ashleve ashleve merged commit fb7c206 into ashleve:main Feb 19, 2022
@ashleve
Copy link
Owner

ashleve commented Feb 19, 2022

I added some explanatory comments and restored storage, study_name, n_jobs, n_startup_trials, since I believe those are quite important. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants