Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor task_wrapper decorator #488

Merged
merged 2 commits into from
Dec 18, 2022
Merged

Refactor task_wrapper decorator #488

merged 2 commits into from
Dec 18, 2022

Conversation

ashleve
Copy link
Owner

@ashleve ashleve commented Dec 18, 2022

What does this PR do?

Refactors task_wrapper decorator to make it more clean.

Adds more explanation comments.

Removes saving execution time to simplify task wrapper.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022

Codecov Report

Base: 84.46% // Head: 83.71% // Decreases project coverage by -0.74% ⚠️

Coverage data is based on head (41c941e) compared to base (ac93624).
Patch coverage: 62.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   84.46%   83.71%   -0.75%     
==========================================
  Files           9        9              
  Lines         354      350       -4     
==========================================
- Hits          299      293       -6     
- Misses         55       57       +2     
Impacted Files Coverage Δ
src/utils/utils.py 60.57% <62.50%> (-3.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants