Handle regular changes of referenced System.Reflection.Metadata version #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion of System.Reflection.Metadata library
|
@TessenR Thanks a lot, I'll clarify a few things and should be OK to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Reflection.Metadata version which Roslyn depends on changes every couple of days lately (https://github.com/dotnet/roslyn/commits/master/src/Dependencies/Metadata/project.json). This issue usually breaks TryRoslyn's compilation or dependency injection behavior (e.g. master branch is completely broken currently in the latest TryRoslyn version)
Fix should take care of it by patching sites' packages and references based on corresponding Roslyn branch.