Migration to clap 3.0 and additional unit test coverage
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* unit test * clap2 deprecated function replaced with clap3
because of the change in the core library.
|
@ashuio , I have started porting the code to |
|
Thanks for taking the initiative, I'll see how i can help too |
kiavash-at-work
changed the title
clap 3.0clap 3.0 and additional unit test coverage
kiavash-at-work
commented
Feb 16, 2022
shavee-core/src/zfs.rs
Outdated
| } | ||
| Err(error) => return Err(error.into()), | ||
| }; | ||
| #[derive(Debug, PartialEq)] |
There was a problem hiding this comment.
Converted the zfs module to OO programming to use Struct and Module.
kiavash-at-work
commented
Feb 16, 2022
shavee-core/src/zfs.rs
Outdated
| } | ||
| //TODO: Modify the trait function to return _Self_ to enable chain actoions: dataset.loadkey(passphrase).mount() | ||
| impl Dataset { |
There was a problem hiding this comment.
Functions now are changed to methods.
|
These are remaining tasks marked in the code as:
|
|
This PR is ready for merge. I will open new trackers for remaining TODO lists |
3 tasks
Additional integration test to cover issue #22. Currently it checks for error message.
|
Sorry for the delay with the merge, Thanks for your contribution |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clap 2.0functions/features that are now deprecated inClap 3.0.