Add file storage for SQLite. Add integration tests. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslotte
reviewed
Jun 7, 2020
| public void CreateExperimentAsync_Success() | ||
| { | ||
| //Arrange | ||
| MLLifeCycleManager mlm = new MLLifeCycleManager(); |
There was a problem hiding this comment.
Super awesome that you're adding the first tests! For a convention, I think it would be nice if we call the class we are testing either classUnderTest or unitUnderTest, I'll let you decide between those two :)
There was a problem hiding this comment.
I'm not sure this is what you meant, I put CreateExperimentAsync_Always_ReturnsNonEmptyGuid and UploadModelAsync_ValidModelPath_UploadSuccess
Closed
aslotte
reviewed
Jun 7, 2020
| @@ -4,10 +4,10 @@ namespace MLOps.NET.SQLite | |||
| { | |||
| public static class MLLifeCycleManagerExtensions | |||
| { | |||
| public static MLLifeCycleManager UseSQLite(this MLLifeCycleManager mLLifeCycleManager) | |||
| public static MLLifeCycleManager UseSQLite(this MLLifeCycleManager mLLifeCycleManager, string destrinationFolder) | |||
There was a problem hiding this comment.
Suggested change
| public static MLLifeCycleManager UseSQLite(this MLLifeCycleManager mLLifeCycleManager, string destrinationFolder) | |
| public static MLLifeCycleManager UseSQLite(this MLLifeCycleManager mLLifeCycleManager, string destrinationFolder = "C:\MLOps") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
#34 #51
Description
I have added two integration tests (one for creating an experiment in sqlite db and another one for uploading a model file)