Remove invalid ref to err #97
Conversation
| func (s *ChaosTestSuite) TestInvalidKillType() { | ||
| v := s.chaos.victim.(*victimMock) | ||
| killValue := 1 | ||
| v.On("KillType", s.client).Return("InvalidKillTypeHere", nil) |
There was a problem hiding this comment.
Do you know how this would behave if the pod/app had an invalid value for KillType and no value for KillValue?
There was a problem hiding this comment.
The killValue is assigned on line 109 and if that operation fails it returns an error.
That logic seems to be in eligible_daemonsets.go/eligigle_statefulsets.go. There are some checks there to assert that the value is a positive int so I think we're cool.
There was a problem hiding this comment.
I'm wondering more of the case where someone sets an invalid KillType on their pod, and no KillValue.
It seems like we will check KillValue (line 109, chaos.go), get an error and terminate a single pod (line 112) despite the incorrect value for KillType.
Does that sound correct? If yes, lets file that as an Issue and fix it separately.
|
Wow thanks for catching this. My bad for copy pasting the error messages. |
Using an invalid kill type causes a "invalid memory address or nil pointer" error to occur.
This is caused by a reference to an uninitialised err.
This pull request fixes issue #96.