fix comments behavior on multiple lines with indentation #86

[KeisukeFD]

I tried to improve the comments behaviour on multiple lines, with indentation. Let me know what you think.

[asottile]

if I'm reading correctly this breaks the following:

    hello
  world
     hello

(select all and :comment)

[KeisukeFD]

if I'm reading correctly this breaks the following:

    hello
  world
     hello

(select all and :comment)

You right ! I'll try to fix that.

[KeisukeFD]

It should be fine now.

Let me know if you see something or have any comments.

[KeisukeFD]

Hi @asottile,

I tried to fix the behaviour with tabs indentation, should be correct now.
However, I can't make the tests work properly, because for some reason, when I check for '\t' in the await_text, it's completely ignored and replaced by spaces instead.

That's the reason why the code coverage failed in the last check.

[asottile]

babi renders tabs as spaces so the expected output should be indentation with spaces (you can save the file and validate the contents to check that tabs are preserved)

[KeisukeFD]

Ok !
So I added the tests for tabs (replaced by spaces in the await_text) to have the code coverage corrected.

[KeisukeFD]

Hi @asottile,

I modified the way the comments was implemented before.
But, I don't know why the code coverage is not full yet.. I don't see what test is missing...

[asottile]

ah yeah that bit of coverage output is confusing if you haven't seen it before:

babi/file.py     611      0    194      1    99%   709->714

this means that the code never branches from like 709 to line 714

in this case I think it means that one of those if statements is always true in this if-tree: https://github.com/asottile/babi/pull/87/files#diff-682b0b8b14eb28e9e1c8793ac95b28a4R709

I think else: raise AssertionError('unreachable') would fix that

[KeisukeFD]

ah yeah that bit of coverage output is confusing if you haven't seen it before:

babi/file.py     611      0    194      1    99%   709->714

this means that the code never branches from like 709 to line 714

in this case I think it means that one of those if statements is always true in this if-tree: https://github.com/asottile/babi/pull/87/files#diff-682b0b8b14eb28e9e1c8793ac95b28a4R709

I think else: raise AssertionError('unreachable') would fix that

Thanks.

[asottile]

I fixed up a few things, it was handling this incorrectly:

# foo print('# bar')

it was stripping both of the # characters

I also simplified comment_add (removed all of the logic there)

[KeisukeFD]

I fixed up a few things, it was handling this incorrectly:

# foo print('# bar')

it was stripping both of the # characters

I also simplified comment_add (removed all of the logic there)

Thanks man ! I'll check your modification to see what I did the wrong way. Happy to help !