-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): add query verb with initial preset features #57
Conversation
1dabb3e
to
140ec6b
Compare
5642ce7
to
18fedf6
Compare
"determine why a target depends on another" the prompts are "target" and "dependency" and at least to me, it's not clear which direction the arrow points. But, then in your next demo that won't work since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes off the top of my head for this:
-
Have we agreed on the preset format? Where does this live? I see we have both an .aspect and a plugins file. I generally dislike so many files in the repo root, and adding another one for presets just adds to that. Can we merge these?
-
There seems to be quite a large amount of boiler plate to add a verb, and we want presets for query, cquery and aquery. As an extension to this, it seems tricky to get the flags to pass though?
@alexeagle does something like this work better? |
23b2d2d
to
6593d4f
Compare
@JesseTatasciore We have to keep our errors compliant with https://go.googlesource.com/proposal/+/master/design/go2draft-error-handling-overview.md. Kinda hard to enforce but we should strive for it. |
I think you have to rebase before merging because of my changes to docs generation. |
…r if statement, print to streams instead of command line
Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
613bd4f
to
029d1c1
Compare
Add query functionality. Users can provide regular bazel queries that will be passed directly to bazel. Users can also take advantage of predefined queries that will simply prompt the user for bazel label(s) as needed