site-packages symlink forest in venv #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
siddharthab
changed the title
This emulates the behavior where a single site-packages directory contains all/most PyPi packages. Packages distributed by NVIDIA currently assume this through the use of rpath as `$ORIGIN/../../` to reach the `nvidia` package location. Downstream libraries like torch and jax do not set up the dynamic library search path based on sys.path either. This is a casual attempt, but can be refined by others. TODO: [] Build binaries for all architectures. Fixes #274.
siddharthab
force-pushed
the
site-packages
branch
from
a91bf72
to
3036800
Compare
|
Note, at HEAD we no longer have checked-in binaries so you can remove that when you rebase. I'm very +1 to having compatibility with ~all existing packages and satisfying the assumptions they make. I can't read Rust yet so handing to Matt. |
|
Thanks for this! Will try to take a look soon. |
mattem
reviewed
Mar 19, 2024
mattem
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This emulates the behavior where a single site-packages directory
contains all/most PyPi packages. Packages distributed by NVIDIA
currently assume this through the use of rpath as
$ORIGIN/../../to reach the
nvidiapackage location. Downstream libraries like torchand jax do not set up the dynamic library search path based on sys.path
either.
This is a casual attempt, but can be refined by others.
Fixes #274.