-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: don't cancel concurrent main builds #342
Conversation
Oddly I got the following checksum error on the test-release CI job:
Fixed in 2nd commit |
33edac4
to
a1f43f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the commit body with the motivation and reasons behind this change and split into two PRs for landing.
Looks like main was broken on the last landed commit by this PR #333. I'll pre-factor the fix into a separate PR. |
a1f43f1
to
bf9655f
Compare
Fixing this in all our rulesets.
This updates the GHA ci.yaml
concurrency
block to match all of our other rule sets. In particular, thecancel-in-progress
is updated to not cancel in progress main builds${{ github.ref_name != 'main' }}
so that if two commits land on main back-to-back the 2nd one does not cancel the first if it is still running CI.