Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make configuration files optional #51

Merged
merged 2 commits into from
Dec 3, 2022

Conversation

davidbrochart
Copy link
Contributor

Now that we can pass configuration at the command line, I guess that configuration files become optional.

@coveralls
Copy link

coveralls commented Dec 3, 2022

Coverage Status

Coverage remained the same at 97.26% when pulling 87714a5 on davidbrochart:optional_yaml into b651db8 on asphalt-framework:master.

@agronholm
Copy link
Member

I'm not sure about this. Is this really practical?

@davidbrochart
Copy link
Contributor Author

I think yes. I have a project where I use Asphalt, and it can run with no configuration file (the only thing it needs is the component.type).
But more generally, I don't see why configuration from file would be required, since you can also configure it through the command line.

@agronholm agronholm merged commit 1d9f993 into asphalt-framework:master Dec 3, 2022
@agronholm
Copy link
Member

Alright, I don't see any real harm from this.

@davidbrochart davidbrochart deleted the optional_yaml branch December 3, 2022 11:24
agronholm added a commit that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants