fix dotfile "dot-" directory handling bug #33 and #56727 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of #70? |
Yeah, it appears that #70 already solved this issue way before me, for some reason the PR didn't show up under #33 when I was looking into the issue. I feel like my fix is simpler as it only adds 6 simple lines of code, without changing much, but it is regex and a bit of an inefficient patch so #70 might be the better choice in the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix GitHub bug #33 and GNU #56727 by attempting to restore target $path with regex if it doesn't exist.
Might slightly slow the process down, as it's now checking the directory twice every single stow_contents() call, but it's the least intrusive fix i could come up with.