-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .Net 7 Check to ClientAssets #572
Conversation
Would it be better to have the condition be for all versions equal to or above 6.0? |
...osoft.AspNetCore.ClientAssets/build/netstandard2.0/Microsoft.AspNetCore.ClientAssets.targets
Outdated
Show resolved
Hide resolved
Blocked pending the resolution of an email thread about whether this PR would be good opportunity to add a project capability. |
@@ -18,6 +18,7 @@ | |||
|
|||
<ItemGroup> | |||
<ClientAssetsInputs Include="$(ClientAssetsDirectory)**" Exclude="$(DefaultItemExcludes)" /> | |||
<ProjectCapability Include="ClientAssetsAlpha"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference would be to not include Alpha
suffix. I wonder if it'll be possible to differentiate telemetry based on the package version itself (@DamianEdwards do you know?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we don't get good signal on package versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want a signal for these versions so once we decide to change it, if it becomes a package, we can differentiate usages as @DamianEdwards says.
Can we get an updated NuGet for this? Even prerelease would be fine. It seems that https://www.nuget.org/packages/Microsoft.AspNetCore.ClientAssets/ is still at v0.1.0-alpha.21528.2 and this prevents us to update to .net 7.0. |
@mkArtakMSFT did you publish the package for this? |
Any updates on getting another nuget release for this change -- even an alpha? |
@mkArtakMSFT can you push an updated version of the package? |
While the effort continues to productionize Microsoft.AspNetCore.ClientAssets, there needs to be an updated check to make sure that customers upgrading to .Net 7 don't break.
CC @mkArtakMSFT
Fixes dotnet/aspnetcore#45849