Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .Net 7 Check to ClientAssets #572

Merged
merged 4 commits into from
Jan 12, 2023

Conversation

Nick-Stanton
Copy link
Contributor

While the effort continues to productionize Microsoft.AspNetCore.ClientAssets, there needs to be an updated check to make sure that customers upgrading to .Net 7 don't break.

CC @mkArtakMSFT

Fixes dotnet/aspnetcore#45849

@Nick-Stanton
Copy link
Contributor Author

Would it be better to have the condition be for all versions equal to or above 6.0?

@Nick-Stanton
Copy link
Contributor Author

Blocked pending the resolution of an email thread about whether this PR would be good opportunity to add a project capability.

@@ -18,6 +18,7 @@

<ItemGroup>
<ClientAssetsInputs Include="$(ClientAssetsDirectory)**" Exclude="$(DefaultItemExcludes)" />
<ProjectCapability Include="ClientAssetsAlpha"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference would be to not include Alpha suffix. I wonder if it'll be possible to differentiate telemetry based on the package version itself (@DamianEdwards do you know?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we don't get good signal on package versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want a signal for these versions so once we decide to change it, if it becomes a package, we can differentiate usages as @DamianEdwards says.

@Nick-Stanton Nick-Stanton merged commit 197bf19 into aspnet:main Jan 12, 2023
@Nick-Stanton Nick-Stanton deleted the UpdateClientAssets branch January 12, 2023 15:52
@lscorcia
Copy link

lscorcia commented Mar 23, 2023

Can we get an updated NuGet for this? Even prerelease would be fine. It seems that https://www.nuget.org/packages/Microsoft.AspNetCore.ClientAssets/ is still at v0.1.0-alpha.21528.2 and this prevents us to update to .net 7.0.

@javiercn
Copy link
Member

@mkArtakMSFT did you publish the package for this?

@austinmcdaniel
Copy link

Any updates on getting another nuget release for this change -- even an alpha?
@javiercn @mkArtakMSFT

@javiercn
Copy link
Member

@mkArtakMSFT can you push an updated version of the package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft.AspNetCore.ClientAssets has a check for .NET6 so it fails on .NET7
6 participants