Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Https][Tooling] Add digital signature to the KeyUsage of the HTTPS dev-cert #9293

Merged
merged 3 commits into from Apr 12, 2019
Merged

[Https][Tooling] Add digital signature to the KeyUsage of the HTTPS dev-cert #9293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6d2e23
[Https][Tooling]
javiercn Apr 11, 2019
f6bd84c
Update devcert tests
javiercn Apr 11, 2019
1d7a394
Fix tests
javiercn Apr 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Shared/CertificateGeneration/CertificateManager.cs
View file
Open in desktop
Expand Up @@ -156,7 +156,7 @@ public X509Certificate2 CreateAspNetCoreHttpsDevelopmentCertificate(DateTimeOffs
var sanBuilder = new SubjectAlternativeNameBuilder();
sanBuilder.AddDnsName(LocalhostHttpsDnsName);

var keyUsage = new X509KeyUsageExtension(X509KeyUsageFlags.KeyEncipherment, critical: true);
var keyUsage = new X509KeyUsageExtension(X509KeyUsageFlags.KeyEncipherment | X509KeyUsageFlags.DigitalSignature, critical: true);
var enhancedKeyUsage = new X509EnhancedKeyUsageExtension(
new OidCollection() {
new Oid(
Expand Down
4 changes: 2 additions & 2 deletions src/Tools/FirstRunCertGenerator/test/CertificateManagerTests.cs
View file
Open in desktop
Expand Up @@ -75,7 +75,7 @@ public void EnsureCreateHttpsCertificate_CreatesACertificate_WhenThereAreNoHttps
httpsCertificate.Extensions.OfType<X509Extension>(),
e => e is X509KeyUsageExtension keyUsage &&
keyUsage.Critical == true &&
keyUsage.KeyUsages == X509KeyUsageFlags.KeyEncipherment);
keyUsage.KeyUsages == (X509KeyUsageFlags.KeyEncipherment | X509KeyUsageFlags.DigitalSignature));

Assert.Contains(
httpsCertificate.Extensions.OfType<X509Extension>(),
Expand Down Expand Up @@ -162,7 +162,7 @@ public void EnsureCreateHttpsCertificate2_CreatesACertificate_WhenThereAreNoHttp
httpsCertificate.Extensions.OfType<X509Extension>(),
e => e is X509KeyUsageExtension keyUsage &&
keyUsage.Critical == true &&
keyUsage.KeyUsages == X509KeyUsageFlags.KeyEncipherment);
keyUsage.KeyUsages == (X509KeyUsageFlags.KeyEncipherment | X509KeyUsageFlags.DigitalSignature));

Assert.Contains(
httpsCertificate.Extensions.OfType<X509Extension>(),
Expand Down