Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Npgsql/EF Core to 6.0.0-preview3 #1659

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

roji
Copy link
Member

@roji roji commented Apr 15, 2021

Since EF Core 6.0.0-preview3 contains the stronger reflection fix (dotnet/efcore#24090), this should make our dashboard work again.

This should start showing the perf improvements from dotnet/efcore#23611.

/cc @ajcvickers

And apply some optimizations
@roji roji requested a review from sebastienros April 15, 2021 20:52
@sebastienros
Copy link
Member

I tried to run it and it didn't work, the packages are not available on our feeds I assume

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/database.benchmarks.yml --scenario fortunes_ef --profile aspnet-perf-lin --application.source.branchOrCommit EFPreview3 --application.source.repository https://github.com/roji/AspNetBenchmarks --application.framework net6.0
/tmp/benchmarks-agent/benchmarks-server-1/1rm1kp1o.2d1/AspNetBenchmarks/src/Benchmarks/Benchmarks.csproj : error NU1102: Unable to find package Npgsql.EntityFrameworkCore.PostgreSQL with version (>= 6.0.0-preview3)
/tmp/benchmarks-agent/benchmarks-server-1/1rm1kp1o.2d1/AspNetBenchmarks/src/Benchmarks/Benchmarks.csproj : error NU1102:   - Found 60 version(s) in dotnet-public [ Nearest version: 6.0.0-preview2 ]

@sebastienros
Copy link
Member

@wtgodbe can you add Npgsql and EF.SQlserver preview3 on the feeds please?

@wtgodbe
Copy link
Contributor

wtgodbe commented Apr 15, 2021

@wtgodbe can you add Npgsql and EF.SQlserver preview3 on the feeds please?

Done

@sebastienros
Copy link
Member

It worked, thanks

@sebastienros sebastienros merged commit 6e37ef1 into aspnet:main Apr 15, 2021
roji added a commit to roji/AspNetBenchmarks that referenced this pull request Apr 30, 2021
roji added a commit to roji/AspNetBenchmarks that referenced this pull request May 4, 2021
roji added a commit to roji/AspNetBenchmarks that referenced this pull request May 4, 2021
roji added a commit to roji/AspNetBenchmarks that referenced this pull request May 5, 2021
@roji roji deleted the EFPreview3 branch September 23, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants