Skip to content
This repository has been archived by the owner on Nov 22, 2018. It is now read-only.

Inject ICorsPolicyProvider instance through Invoke #202

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Nov 9, 2018

This allows for scoped instances of ICorsPolicyProvider to be injected in the CORS middleware and prevents turning them into singletons.

Resolves dotnet/aspnetcore#2377

This allows for scoped instances of `ICorsPolicyProvider` to be injected in the CORS middleware and prevents turning them into singletons.

Resolves #105
@pranavkm
Copy link
Contributor Author

pranavkm commented Nov 9, 2018

Updated version of #106

Copy link
Member

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a'ight to me, but @javiercn is far more of an expert on this.

@pranavkm
Copy link
Contributor Author

pranavkm commented Nov 9, 2018

The code's pretty identical to the original PR. I think there's plans for better design here but merging this in before the repo gets mondo-repoed.

@pranavkm pranavkm merged commit e790a9b into master Nov 9, 2018
@pranavkm pranavkm deleted the prkrishn/105 branch November 9, 2018 22:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants