Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DiscriminatorValue object instead of string #2444

Closed
rmja opened this issue Jun 23, 2015 · 1 comment
Closed

Make DiscriminatorValue object instead of string #2444

rmja opened this issue Jun 23, 2015 · 1 comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
1.0.0

Comments

@rmja
Copy link

rmja commented Jun 23, 2015

The DiscriminatorValue is currently a string, but should be object to allow for e.g. enums to discriminate derived entity types. See e.g. #2057 where a naiive try results in invalid SQL for enum.
@rowanmiller rowanmiller added this to the Investigation milestone Jun 23, 2015
@anpete anpete removed their assignment Jun 23, 2015
@anpete
Copy link
Contributor

anpete commented Jun 23, 2015

I think this is a hangover from when annotations values could only be strings. Should be a small'ish change. Sending back to triage.

@anpete anpete removed this from the Investigation milestone Jun 23, 2015
@rowanmiller rowanmiller added this to the 7.0.0 milestone Jun 26, 2015
@mikary mikary added the 2 - Done label Jul 6, 2015
mikary added a commit that referenced this issue Jul 6, 2015
@mikary
Fix #2444 - change data type of DiscriminatorValue to object.
e8056a2
mikary added a commit that referenced this issue Jul 10, 2015
@mikary
Fix #2444 - change data type of DiscriminatorValue to object.
e396322
@mikary mikary closed this as completed in ef6d194 Jul 10, 2015
@rowanmiller rowanmiller modified the milestones: 7.0.0, 7.0.0-beta6 Jul 15, 2015
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers modified the milestones: 1.0.0-beta6, 1.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
5 participants
@anpete @ajcvickers @rmja @rowanmiller @mikary