Implement DbSet.Find #5800
Merged
Implement DbSet.Find #5800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,312 @@ | |||
| // Copyright (c) .NET Foundation. All rights reserved. | |||
There was a problem hiding this comment.
Don't verify the SQL here unless there is a meaningful difference from SQL Server. We removed this type of verification because it added a significant maintenance burden to query.
There was a problem hiding this comment.
It's also a way of ensuring that the database has/has not been hit. Okay if I change it to empty string verses not empty string?
There was a problem hiding this comment.
Aren't you already getting that verification by using Assert.Same?
|
|
ajcvickers
force-pushed
the
CallTheCops0615
branch
from
fa1621e to
1ff3c24
Compare
Issue #797 Semantics are essentially the same as EF6: - If entity with given key is being tracked, then return it without a database query - Otherwise, query the database and track and return entity if found - Otherwise, return null
ajcvickers
force-pushed
the
CallTheCops0615
branch
from
1ff3c24 to
b814cc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #797
Semantics are essentially the same as EF6: