Migrations: Use reflection order for columns in CreateTable #10075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
Oct 16, 2017
bricelam
commented
Oct 18, 2017
| } | ||
|
|
||
| foreach (var definingForeignKey in entityType.GetDeclaredReferencingForeignKeys() | ||
| .Where(fk => fk.DeclaringEntityType.DefiningEntityType == entityType)) |
There was a problem hiding this comment.
@AndriySvyryd is this this right? In Relational, do navigation-defined entity types always map to the principal entity type's table?
There was a problem hiding this comment.
No, that's just the default.
There was a problem hiding this comment.
K, will add some more tests and react
|
The more code I write, the less confident I become. 😄 I'm doing one last round of bashing before merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2272