This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Updated IISDeployer #860
Merged
Updated IISDeployer #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jhkimnew, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
Tratcher
reviewed
Oct 7, 2016
| @@ -36,13 +36,15 @@ public override DeploymentResult Deploy() | |||
|
|
|||
| _application = new IISApplication(DeploymentParameters, Logger); | |||
|
|
|||
| // Publish to IIS root\application folder. | |||
| DotnetPublish(publishRoot: _application.WebSiteRootFolder); | |||
| if (DeploymentParameters.PublishApplicationBeforeDeployment) | |||
There was a problem hiding this comment.
Don't you always have to publish to run? I think we always publish for express.
There was a problem hiding this comment.
DeploymentParameters.PublishApplicationBeforeDeployment is set to true at the line 35.
So, adding this if condition would not affect any change. IISExpress has the same code logic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pranavkm @Tratcher Please review this PR and approve if you agree so that I can merge this code change on my fork to dev branch.
Brief descripton of the issue:
IIS Deployer has an issue regarding the applicationPath pointing wrong directory instead of publish directory and so I fixed it following the way used by IISExpress Deployer and confirmed the issue is fixed.