This repository has been archived by the owner on Dec 20, 2018. It is now read-only.
Disable parallelization #1944
Merged
Disable parallelization #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
approved these changes
Aug 27, 2018
Eilon
suggested changes
Aug 27, 2018
| using Microsoft.AspNetCore.Testing.xunit; | ||
| using Xunit; | ||
|
|
||
| [assembly: CollectionBehavior(DisableTestParallelization = true)] |
There was a problem hiding this comment.
Actually, can we add a comment here that explains why we did it, and links to the test failure issue?
There was a problem hiding this comment.
Updated with link and some words
This was referenced Aug 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1926
Test running time go from 17s -> 29s locally
@Eilon @ajcvickers