This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
[Wip] Rio Transport #1630
Closed
[Wip] Rio Transport #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Apr 7, 2017
|
|
||
| private void DisposeConnections() | ||
| { | ||
| //try |
There was a problem hiding this comment.
What is this dead code 😄 . @halter73 is working on moving shutdown to kestrel core so you won't have to handle this.
There was a problem hiding this comment.
Is like a todo area :)
benaadams
force-pushed
the
rio
branch
6 times, most recently
from
6f30dc2
to
bc4104a
Compare
|
Closing this as "stale" :) Thanks Ben! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample
TransportChoiceAppruns and works for benchmarking, otherwise is currently rougher than sand paperdotnet run -c Release -f netcoreapp2.0Then option 1 or 2
Not sure why it seems to listen on a different IP based on choice though (127.0.0.1 vs 127.0.0.127)