Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Tag Helpers: add support for @ in a tag helper attribute value #1253

Closed
dougbu opened this issue Oct 6, 2014 · 3 comments
Closed

Tag Helpers: add support for @ in a tag helper attribute value #1253

dougbu opened this issue Oct 6, 2014 · 3 comments
Assignees
@dougbu
Labels
3 - Done enhancement
Milestone
1.0.0-beta3

Comments

@dougbu
Copy link
Member

dougbu commented Oct 6, 2014

specifically, add support for a leading @ in an expression the user types. this enables use of expressions that are not model properties e.g.

  @for (var item in Model)
  {
    <input type="text" for="@item" />
  }
This was referenced Oct 6, 2014
Closed
Closed
@danroth27 danroth27 added this to the 6.0.0-rc1 milestone Oct 7, 2014
@NTaylorMullen NTaylorMullen mentioned this issue Oct 7, 2014
Closed
@dougbu dougbu mentioned this issue Oct 13, 2014
Closed
@danroth27 danroth27 mentioned this issue Oct 20, 2014
Closed
@rynowak
Copy link
Member

rynowak commented Nov 20, 2014

See: ProcessAsync_CallsGeneratorWithExpectedValues_ItemsAndMultiple for a test that needs to be updated when this is fixed.

@dougbu dougbu self-assigned this Jan 11, 2015
@dougbu dougbu mentioned this issue Jan 11, 2015
Closed
dougbu added a commit to aspnet/Razor that referenced this issue Jan 12, 2015
@dougbu
Handle complex expressions for bound non-string tag helper attributes
3d9caa8 
- #129 and aspnet/Mvc#1253
- add new `CSharpTagHelperAttributeValueVisitor` that writes the raw expression
- update existing tests to include new line pragmas and updated line mappings
- add tests of embedded `@(...)` and mix that with normal expressions

nits:
- cleanup long lines in `CSharpTagHelperCodeRenderer`
- ease debugging of `LineMapping` values
- improve assertion failures about code mapping miss-matches
- add `GENERATE_BASELINES` reminder to test project.json
@dougbu dougbu mentioned this issue Jan 12, 2015
Merged
dougbu added a commit to aspnet/Razor that referenced this issue Jan 15, 2015
@dougbu
Handle complex expressions for bound non-string tag helper attributes
0209f56 
- #129 and support aspnet/Mvc#1253
- add new `CSharpTagHelperAttributeValueVisitor` that writes the raw expression
- add tests of embedded `@(...)` and mix that with normal expressions
- add new resources for errors in `CSharpTagHelperAttributeValueVisitor`
- update baselines to match new code generation

nits:
- cleanup long lines in `CSharpTagHelperCodeRenderer`
- remove a few unused resources

CR comments: Do not `throw` in `CSharpTagHelperAttributeValueVisitor`
- use `ParserErrorSink` instead
- add error if bound non-`string` attribute value is empty (don't handle)
- move `#line` pragma to surround entire bound attribute value assignment
 - need non-`null` `ChunkBlock.Association` value for this to work
- clean up some whitespace special-cases needed for previous approach
dougbu added a commit that referenced this issue Jan 15, 2015
@dougbu
React to aspnet/Razor#268 changes
aff39c7 
- address #1253 using new Razor capabilities
- update baselines to match latest code generation
- use new `CodeBuilderContext` and `TagHelperAttributeValueCodeRenderer` signatures
- test complex expressions in bound non-string attribute values
@dougbu dougbu mentioned this issue Jan 15, 2015
Closed
@dougbu dougbu changed the title Tag Helpers: support user typing entire RHS of a ModelExpression lambda expression Tag Helpers: add support for @ in a tag helper attribute value Jan 15, 2015
@dougbu
Copy link
Member Author

dougbu commented Jan 15, 2015

previous title was "support user typing entire RHS of a ModelExpression lambda expression"

example attribute values to support:

<select
    asp-for="@(Model.YearsEmployeed)"
    asp-items="@((IEnumerable<SelectListItem>)ViewBag.Items)">
 ...
</select>

<cache vary-by-user="@DateTimeOffset.Now > @(DateTimeOffset.Parse("1 April 2015"))">
 ...
</cache>

dougbu added a commit that referenced this issue Jan 15, 2015
@dougbu
Allow @Model in bound tag helper attribute value
67a3acd 
- part II of #1253
- an expected case in template .cshtml files
- expression has name `""`; led to `ArgumentException` in `ModelExpression`
- test `@Model` and `@model.Property` in unit and functional tests
- update baselines to match

nit: remove a few unecessary `@`s in .cshtml files
dougbu added a commit that referenced this issue Jan 15, 2015
@dougbu
React to aspnet/Razor#268 changes
5f5791e 
- address part I of #1253 using new Razor capabilities
- update baselines to match latest code generation
- use new `CodeBuilderContext` and `TagHelperAttributeValueCodeRenderer` signatures
- test complex expressions in bound non-string attribute values
dougbu added a commit that referenced this issue Jan 15, 2015
@dougbu
Allow @Model in bound tag helper attribute value
ecd5766 
- part II of #1253
- an expected case in template .cshtml files
- expression has name `""`; led to `ArgumentException` in `ModelExpression`
- test `@Model` and `@model.Property` in unit and functional tests
- update baselines to match

nits:
- remove a few unecessary `@`s in .cshtml files
- correct field names & ids in ProductList.cshtml (`foreach` confuses MVC)
 - led to correct valiation attributes as well
dougbu added a commit to aspnet/Razor that referenced this issue Jan 16, 2015
@dougbu
Handle complex expressions for bound non-string tag helper attributes
de4cafa 
- #129 and support aspnet/Mvc#1253
- add new `CSharpTagHelperAttributeValueVisitor` that writes the raw expression
- add tests of embedded `@(...)` and mix that with normal expressions
- add new resources for errors in `CSharpTagHelperAttributeValueVisitor`
 - write errors using `ParserErrorSink`
- update baselines to match new code generation

nits:
- cleanup long lines in `CSharpTagHelperCodeRenderer`
- remove a few unused resources
dougbu added a commit that referenced this issue Jan 16, 2015
@dougbu
React to aspnet/Razor#268 changes
22ba1ef 
- part I of #1253 using new Razor capabilities
- update baselines to match latest code generation
- use new `CodeBuilderContext` and `TagHelperAttributeValueCodeRenderer` signatures
- test complex expressions in bound non-string attribute values
dougbu added a commit that referenced this issue Jan 16, 2015
@dougbu
Allow @Model in bound tag helper attribute value
9165cc9 
- part II of #1253
- an expected case in template .cshtml files
- expression has name `""`; led to `ArgumentException` in `ModelExpression`
- test `@Model` and `@model.Property` in unit and functional tests
- update baselines to match

nits:
- remove a few unecessary `@`s in .cshtml files
- correct field names & ids in ProductList.cshtml (`foreach` confuses MVC)
 - led to correct valiation attributes as well
dougbu added a commit that referenced this issue Jan 16, 2015
@dougbu
React to aspnet/Razor#268 changes
a77d071 
- part I of #1253 using new Razor capabilities
- update baselines to match latest code generation
- use new `CodeBuilderContext` and `TagHelperAttributeValueCodeRenderer` signatures
- test complex expressions in bound non-string attribute values
dougbu added a commit that referenced this issue Jan 16, 2015
@dougbu
Allow @Model in bound tag helper attribute value
d2fe1eb 
- part II of #1253
- an expected case in template .cshtml files
- expression has name `""`; led to `ArgumentException` in `ModelExpression`
- test `@Model` and `@model.Property` in unit and functional tests
- update baselines to match

nits:
- remove a few unecessary `@`s in .cshtml files
- correct field names & ids in ProductList.cshtml (`foreach` confuses MVC)
 - led to correct valiation attributes as well
@dougbu
Copy link
Member Author

dougbu commented Jan 16, 2015

Fixed with a77d071 and d2fe1eb

@dougbu dougbu closed this as completed Jan 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-beta3
Development

No branches or pull requests
3 participants
@rynowak @danroth27 @dougbu