This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Dispose implementations should not be treated as action methods #1294
Milestone
Comments
Would |
We already handle object methods specially |
We should also add Dispose to Controller. |
We already have Dispose in the Controller so that is a non-issue. We still need to address the POCO controller case though. Working on the fix that will work for the POCO case too. |
kanchanm
added a commit
that referenced
this issue
Nov 6, 2014
Commit 4598505 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently if you implement IDisposable on a controller class then your
Dispose
method will be treated as an action unless you attribute it with[NonAction]
.The old controller base classes in both MVC and WebAPI were already IDisposable, but the new one is not, so users will end up defining a dispose method if they need it.
We should special case Dispose to treat it as not-an-action by default.
The text was updated successfully, but these errors were encountered: