Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

TagBuilder attributes are case sensitive. HTML5 spec says attributes are now case insensitive. Change TagBuilder & infrastructure. #1328

Closed
NTaylorMullen opened this issue Oct 10, 2014 · 2 comments
Assignees
Milestone

Comments

@NTaylorMullen
Copy link
Member

Since we're now changing our framework to follow the HTML5 standards we should also modify things like TagBuilder to follow them. In XHTML the standard for attribute was for them to be case sensitive; that's changed, in HTML 5 they're case insensitive. This bug also involves modifying HTML helpers to abide by case insensitive attributes.

@NTaylorMullen
Copy link
Member Author

@danroth27 Does this mean that aspnet/Razor#186 also goes in sprint backlog/beta1?

@danroth27 danroth27 modified the milestones: 6.0.0-beta2, 6.0.0-beta1 Oct 17, 2014
NTaylorMullen added a commit that referenced this issue Oct 20, 2014
- This involved adding the StringComparer.OrdinalIgnoreCase comparer to the TagBuilder's Attributes dictionary.
- Added tests to validate that all methods that made use of TagBuilder.Attributes abide by the new ignore case mechanic.

#1328
NTaylorMullen added a commit that referenced this issue Oct 20, 2014
- This involved adding the StringComparer.OrdinalIgnoreCase comparer to the TagBuilder's Attributes dictionary.
- Added tests to validate that all methods that made use of TagBuilder.Attributes abide by the new ignore case mechanic.

#1328
@NTaylorMullen NTaylorMullen changed the title TagBuilder attributes are case sensitive. HTML5 spec says attributes are now case insensitive. TagBuilder attributes are case sensitive. HTML5 spec says attributes are now case insensitive. Change TagBuilder & infrastructure. Oct 23, 2014
NTaylorMullen added a commit that referenced this issue Oct 26, 2014
…insensitive.

- This involved adding the StringComparer.OrdinalIgnoreCase comparer to the TagBuilder's Attributes dictionary.
- Added tests to validate that all methods that made use of TagBuilder.Attributes abide by the new ignore case mechanic.
- Added two sets of tests to validate the new functionality of Object => Dictionary HTML helper tests.
- Modified a functional test that utilizes HTML Helpers to provide same attribute-different case objects.
- Fixed existing HTML helper tests to account for new ordering of attrbutes (dictionary no longer adds key value pairs, it sets them).

#1328
@NTaylorMullen
Copy link
Member Author

09af7bb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants