Consider some cleanup on MvcOptions.ApplicationModelConventions

[rynowak]

1) Consider shortening the property name:

services.Configure<MvcOptions>(options =>
{
    options.ApplicationModelConventions.Add(new CoolRoutingConvention());
});

VS

services.Configure<MvcOptions>(options =>
{
    options.Conventions.Add(new CoolRoutingConvention());
});

2) Consider extension methods for adding any type of convention to the options

Right now options only supports adding IApplicationModelConvention - if you want to operate controllers/actions/parameters, you have have to write a bunch of for-loops. We could provide convenience overloads for you.

From functional tests:

public class ApiExplorerVisibilityEnabledConvention : IApplicationModelConvention
{
        public void Apply(ApplicationModel application)
        {
            foreach (var controller in application.Controllers)
            {
                if (controller.ApiExplorerIsVisible == null)
                {
                    controller.ApiExplorerIsVisible = true;
                    controller.ApiExplorerGroupName = controller.ControllerName;
                }
            }
        }
}

VS

public class ApiExplorerVisibilityEnabledConvention : IControllerConvention
{
        public void Apply(ControllerModel controller)
        {
                if (controller.ApiExplorerIsVisible == null)
                {
                    controller.ApiExplorerIsVisible = true;
                    controller.ApiExplorerGroupName = controller.ControllerName;
                }
        }
}

[yishaigalatzer]

Specifically for item number 2, you need only to support a controller convention for every controller

Conventions.Add(new ControllerModelConvention());  // apply to all controllers, and check for the controller type in the convention if you care.

and not

Conventions.Add<HomeController>(new ControllerModelConvention()); // apply to a specific controller

Similarly should we have the same thing for all actions? I think yes. e.g. make all parameters with [FromHeader] required

[sornaks]

d2c3985