This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Make string-based expression evaluations behave consistently
#2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #1485, #1487 - handle `TemplateInfo.HtmlFieldPrefix` in `ViewDataEvaluator.Eval()` - attempt lookup in the `ViewDataDictionary` using full name then evaluate relative `expression` against `viewData.Model` - handle `null` or empty `expression` special case in this method (remove `throw`s) - always pass relative `expression` name into `Eval()` - remove `null` or empty `expression` handling from higher-level code - in a couple of cases, special-case returned `ViewDataInfo` - #2662 - remove incorrect guard from `DefaultHtmlGenerator.GenerateRadioButtion()` - add doc comments for the core methods that have changed - enable unit tests skipped due to one of above bugs - fix one (yeah, just one) other test with incorrect expectations - remove functional test comments about the above bugs and update expectations nits: - move some comments describing `ViewDataEvaluator` methods above the methods
|
ping @rynowak |
| @@ -1194,7 +1185,11 @@ private static string GetInputTypeString(InputType inputType) | |||
| string expression) | |||
| { | |||
| var value = viewContext.ViewData.Eval(expression); | |||
There was a problem hiding this comment.
Add comment about expecting user to provide select list items in the dictionary and (definitely) not as the Model.
|
Offline |
from
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modelvalues if called from templates #1485, Most string-based HTML helpers use unprefixedViewDataDictionaryentries if called from templates #1487TemplateInfo.HtmlFieldPrefixinViewDataEvaluator.Eval()ViewDataDictionaryusing full name then evaluaterelative
expressionagainstviewData.Modelnullor emptyexpressionspecial case in this method (removethrows)expressionname intoEval()nullor emptyexpressionhandling from higher-level codeViewDataInfoRadioButton(string.Empty)ignoresModelvalue #2662DefaultHtmlGenerator.GenerateRadioButtion()nits:
ViewDataEvaluatormethods above the methods