Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Tooling: Directives are not inheriteted via _GlobalImport.cshtml #2213

Closed
NTaylorMullen opened this issue Mar 19, 2015 · 4 comments
Closed
Assignees
Milestone

Comments

@NTaylorMullen
Copy link
Member

Due to the change here: cfd5630 directives are no longer inherited in the tooling scenario because we short-circuit for rooted paths (tooling passes in rooted paths) in the ViewStartUtility, now ViewHierarchyUtility.

This seems to have regressed at the beginning of December.

@NTaylorMullen NTaylorMullen self-assigned this Mar 19, 2015
@NTaylorMullen NTaylorMullen added this to the 6.0.0-beta4 milestone Mar 19, 2015
@dougbu
Copy link
Member

dougbu commented Mar 20, 2015

how are our tests passing? or what part of the scenario is missing from our test suites?

@NTaylorMullen
Copy link
Member Author

Tooling provides a rooted path for the source file where runtime provides an app relative path.

@dougbu
Copy link
Member

dougbu commented Mar 20, 2015

OIC we were simply not testing the "design-time" scenarios correctly

@NTaylorMullen
Copy link
Member Author

0f1292a
9ac3465

NTaylorMullen added a commit that referenced this issue Mar 21, 2015
- Tooling passes in rooted paths when asking for a RazorParser for a file. This was problematic when resolving inherited code trees and ultimately this commit tests that.

#2213
NTaylorMullen added a commit that referenced this issue Mar 22, 2015
- Tooling passes in rooted paths when asking for a RazorParser for a file. This was problematic when resolving inherited code trees and ultimately this commit tests that.

#2213
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants